Charts and trends

almatoy · May 28, 2022, 9:09pm

Love the charting. Any way we can add the upper and lower limits to the charts so we can identify where we are in the range?

gazzini · May 30, 2022, 11:42pm

Sure!

We actually used to have this feature, but it was thrashed around when we changed how the configurable ideal ranges worked.

Here’s where the app tries to load them:

github.com

pooldash/pd-mobile/blob/develop/src/services/ChartService.ts#L26

    
      
              idealMin: number | null;
              idealMax: number | null;
          }
          // get all different readings & treatments
          let idsToGraph: Graphable[] = [];
          entries.forEach((entry) => {
              entry.readingEntries.forEach((reading) => {
                  const graphable: Graphable = {
                      title: reading.readingName,
                      id: reading.var,
                      idealMin: reading.idealMin || null,
                      idealMax: reading.idealMax || null,
                  };
                  if (
                      idsToGraph.filter((g) => {
                          return g.title === graphable.title && g.id === graphable.id;
                      }).length === 0
                  ) {
                      idsToGraph.push(graphable);
                  } else {
                      // update the ideal range:

However, once I finish a migration to simpler formulas (next week-ish), these should start working again automagically.

Thanks for pointing this out, though… I didn’t realize this was broken!